Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixtures aren't not valid ansi sql #538

Open
hfhbd opened this issue Jul 27, 2023 · 0 comments
Open

Test fixtures aren't not valid ansi sql #538

hfhbd opened this issue Jul 27, 2023 · 0 comments
Labels

Comments

@hfhbd
Copy link
Collaborator

hfhbd commented Jul 27, 2023

Dialect

SQLite

Failing SQL

SELECT 42 WHERE 1 = ?1;

Description

Unfortunately, there is no real ANSI sql standard, because the standard itself is not very strict and every vendor has custom dialects. But the test fixtures should be dialect agnostic as possible.

This includes:

  • No ?1 because this syntax isn't supported by all dialects (eg PostgreSQL R2DBC or DB2)
  • Always add a FROM clause. While almost all dialects do support omitting the FROM clause, DB2 does not.

One simple option split the test fixtures and the variable into ansi sql and common sql (name to be discussed), which contains the failing test fixtures.

@hfhbd hfhbd added the bug label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant