Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to silence dbt logging #5054 #5070

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Try to silence dbt logging #5054 #5070

merged 2 commits into from
Aug 8, 2023

Conversation

alanmcruickshank
Copy link
Member

Hopefully nice an easy one.

This resolves #5054 (at least until dbt changes their internal APIs).

This attempts to clear the internal logger handlers (using an existing method which exists within the dbt project).

@coveralls
Copy link

coveralls commented Aug 8, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling ef0bcb6 on ac/dbt_logging into 1a72257 on main.

Copy link
Contributor

@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Is there any way to reproduce / test so we know it’s fixed, at least for some dbt versions?

@alanmcruickshank
Copy link
Member Author

Nice. Is there any way to reproduce / test so we know it’s fixed, at least for some dbt versions?

Yeah good idea - I think I can get something to make sure that the output is valid JSON. 🤔

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 6c2b4c1 Aug 8, 2023
27 checks passed
@alanmcruickshank alanmcruickshank deleted the ac/dbt_logging branch August 8, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--write-output writing invalid JSON when using DBT templater
3 participants