Add KSP support to InjectConstructorFactory, MembersInjectorCodeGen, and assisted injection #795
Conversation
|
Adding some more to this, please hold |
ZacSweers
changed the title
| constructor.parameters.joinToString(", ", prefix = "(", postfix = ")") { param -> | ||
| param.type().asClassReference().shortName | ||
| } |
There was a problem hiding this comment.
Added this opportunistically as the test removes them but it makes it easier to disambiguate in real usages
| if (receiver != null) { | ||
| count++ | ||
| } | ||
| val functionSimpleName = if (count >= 23) { |
There was a problem hiding this comment.
What's the significance of 23 here and why do we care about using N vs the number of params? Maybe add a named constant and/or comment
There was a problem hiding this comment.
Functions that have 23 or more parameters are actually converted to a special FunctionN type that has an arity type, so this accounts for that. We use this logic in Moshi as well.
There was a problem hiding this comment.
First time coming across this, thanks for explaining. Fun related doc: https://android.googlesource.com/platform/external/jetbrains/kotlin/+/refs/heads/mirror-goog-studio-master-dev/spec-docs/function-types.md
| constructorParameters: List<ConstructorParameter>, | ||
| onError: (String) -> Nothing | ||
| ): FileSpec { | ||
| val packageName = clazz.packageName |
There was a problem hiding this comment.
Do you know if ClassName#packageName handles the root case? Basically verifying that we do not need the extra logic from safePackageString here anymore.
There was a problem hiding this comment.
I believe so, insofar as it just returns an empty string for root packages. KP allows empty strings for package names
| /** | ||
| * Parameters for configuring [AnvilCompilationMode] and whether to run a full test run or not. | ||
| */ | ||
| internal fun useDaggerAndKspParams( |
…tegration * main: (21 commits) properly parse `--tests` parameters in `CompositePlugin` fix `:gradle-plugin`'s plugin application order misc cleanup only apply the benchmark plugin to the main build's root remove the explicit task delegation from the ktlint plugin don't include the benchmark build as part of the main build fix project paths in ci workflow don't bundle the publishing plugin application into the library plugin add kdoc to CompositePlugin Put `sample` and `integration-tests` into the delegate build introduce `BasePlugin` and `MinimalPlugin` conventions fix the `plugin-integration-tests` job's name making a better composite build add basic Gradle integration test scaffolding Revert "Update kotlinpoet to v1.15.3" Add KSP support to InjectConstructorFactory, MembersInjectorCodeGen, and assisted injection (#795) Update kotlinpoet to v1.15.3 Update dependency com.rickbusarow.kgx:kotlin-gradle-extensions to v0.1.9 Update ktlintPlugin to v12 Apply KtLint to the unpublished modules ... # Conflicts: # build-logic/delegate/settings.gradle # gradle-plugin/build.gradle # gradle/libs.versions.toml # sample/app/build.gradle
These were done together as they are linked. Tried to share code where possible, but there are some meaty parts in dagger generation util that I couldn't really easily share much.
Note that one test is disabled in KSP until binding module generation supports KSP, and I felt it best to save that for a later PR since that generator requires some reworking to avoid class merging during generation.
I also fixed a few mis-named files along the way.
Ref: #751