Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate project to Kotlin multi-platform structure #306

Closed
wants to merge 1 commit into from

Conversation

Egorand
Copy link
Collaborator

@Egorand Egorand commented Dec 18, 2017

Closes #304

@Egorand
Copy link
Collaborator Author

Egorand commented Dec 18, 2017

Just a POC so far to open the discussion. Most of the code is currently in kotlinpoet-jvm, common module only contains stuff that was easy to migrate. It's not possible to use Truth in the common module, so all tests have to be changed to only use Kotlin's assertions.

@Egorand
Copy link
Collaborator Author

Egorand commented Dec 18, 2017

@JvmStatic, @JvmField and @JvmOverloads are missing from kotlin-stdlib-common, that looks like a showstopper. Related to https://youtrack.jetbrains.com/issue/KT-18882

@JakeWharton
Copy link
Collaborator

JakeWharton commented Feb 23, 2018 via email

@swankjesse
Copy link
Collaborator

Decline this for now?

@Egorand
Copy link
Collaborator Author

Egorand commented Feb 26, 2018

Yeah, as discussed, this doesn't bring a lot of value at the moment, let's revisit later

@Egorand Egorand closed this Feb 26, 2018
@Egorand Egorand deleted the egorand/multiplatform branch April 21, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants