Defer StreamResetException until response body buffer is fully read. #3960
+71
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is the right approach but I thought it was good enough to get a discussion started. |
yschimke
reviewed
Apr 8, 2018
pom.xml
Outdated
| @@ -164,7 +164,6 @@ | |||
| <systemPropertyVariables> | |||
| <okhttp.platform>${okhttp.platform}</okhttp.platform> | |||
| </systemPropertyVariables> | |||
| <redirectTestOutputToFile>true</redirectTestOutputToFile> | |||
There was a problem hiding this comment.
temporary change? removing this overwhelms the normal Travis logs.
There was a problem hiding this comment.
Gotcha, that's unfortunate. I'll revert.
We rely on the application layer to read the response body buffer before sending WINDOW_UPDATE's. Previously we'd immediately throw a StreamResetException. This prevented the application layer from reading the buffer which in turn means we would not send WINDOW_UPDATE's. This has potential to deplete the flow-control window. #3915
dave-r12
force-pushed
the
http2-connection-flow-control
branch
from
914bc56
to
691a82b
Compare
swankjesse
approved these changes
Apr 12, 2018
| @@ -300,6 +301,40 @@ private static OkHttpClient buildHttp2Client() { | |||
| response2.close(); | |||
| } | |||
|
|
|||
| @Test public void connectionWindowUpdateAfterCanceling() throws Exception { | |||
| server.enqueue(new MockResponse() | |||
| .setBody(new Buffer().write(new byte[Http2Connection.OKHTTP_CLIENT_WINDOW_SIZE + 1]))); | |||
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on the application layer to read the response body buffer
before sending WINDOW_UPDATE's. Previously we'd immediately throw a
StreamResetException. This prevented the application layer from reading
the buffer which in turn means we would not send WINDOW_UPDATE's. This
has potential to deplete the flow-control window.
#3915