Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes #6773

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Add .gitattributes #6773

merged 1 commit into from
Jul 28, 2021

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jul 28, 2021

@Goooler Goooler mentioned this pull request Jul 28, 2021
@yschimke
Copy link
Collaborator

What's the benefit of this PR? A windows developer won't get annoyed with random line ending changes?

@Goooler
Copy link
Contributor Author

Goooler commented Jul 28, 2021

What's the benefit of this PR? A windows developer won't get annoyed with random line ending changes?

For example, if I execute gradlew wrapper in Windows, the Windows's default eol is crlf, will chnage the gradlew file, lead to it can't be executable.

@yschimke
Copy link
Collaborator

Is this standard in gradle projects? or cashapp/square projects? I'd push back on extra config that makes any project special.

@Goooler
Copy link
Contributor Author

Goooler commented Jul 28, 2021

Is this standard in gradle projects? or cashapp/square projects? I'd push back on extra config that makes any project special.

See eslint-plugin-square's, gradle's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants