Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow thread disk reads temporarily at onAppCrashing() function #62

Merged

Conversation

fcduarte
Copy link
Contributor

No description provided.

* Records the timestamp of a crash in the application and stores it in shared preferences.
* The write operation is performed synchronously to ensure it is completed before the
* process terminates in the event of a crash.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - move the suppresslint annotation to after the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@fcduarte fcduarte force-pushed the fduarte/allow-disk-reads-onappcrashing branch from 4086724 to 7aa729b Compare September 20, 2023 02:03
Copy link
Contributor

@joshskeen joshskeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshskeen joshskeen merged commit 92cf64d into square:main Oct 30, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants