This repository has been archived by the owner on Aug 29, 2020. It is now read-only.
QUnit 2.9 compatibility #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raycohen
force-pushed
the
rc-temp-qunit-2.6
branch
2 times, most recently
from
3284b00
to
3711326
Compare
raycohen
force-pushed
the
rc-temp-qunit-2.6
branch
from
0fedf27
to
1788289
Compare
raycohen
commented
Dec 12, 2019
lib/qunit-bdd.js
Outdated
| var queue = []; | ||
| if (options.insideFirst) { | ||
| this.gatherHooksInsideFirstHelper(hook, queue); | ||
| return queue.reverse(); |
There was a problem hiding this comment.
to do: explain this with a comment
raycohen
commented
Dec 16, 2019
| console.error(e.stack); | ||
| } | ||
| QUnit.pushFailure( | ||
| 'Exception while running qunit-bdd `' + hook + '` hook: ' + |
There was a problem hiding this comment.
we're duplicating QUnit's notrycatch if/else in order to provide a bdd-tailored exception message. We could return the function without any of this, but then an error from a qunit-bdd before would have a message stating it was coming from a qunit beforeEach which could cause confusion.
raycohen
force-pushed
the
rc-temp-qunit-2.6
branch
4 times, most recently
from
bd2d992
to
da20181
Compare
bmish
approved these changes
Dec 19, 2019
- Breaks compatibility with QUnit < 2.6 - Now matches QUnit's inside-first, bottom-to-top `after` hook ordering
raycohen
force-pushed
the
rc-temp-qunit-2.6
branch
from
4ff0f23
to
74a5ead
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of QUnit 2.4:
assertas the first param andtestEnvironmentas thethiscontext. qunit-bdd had been capturing these manually and calling the hook with them, so that was able to be removed.In QUnit 2.6
Version bump
As this PR breaks backwards compatibility with QUnit 2.5.1 and lower, we will release the next version of qunit-bdd as version 3.0
Other Breaking Changes from qunit-bdd 2.x
qunit-bdd's
afterhook ordering has changed to match QUnit's ordering ofafterandafterEach, which runs hooks at the same level in bottom-to-top order, rather than top-to-bottom order. See qunitjs/qunit#977 and comments in the qunit test code regarding this ordering.