-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic: file x already exists #106
Comments
Try with |
It works this way! |
All right you've got a workaround - it does not analyze all the commits but should be enough for a plain |
You are awesome and indeed it's under NDA. I'm not familiar with go, so I assume it would be hard to debug this repository. |
As requested:
I am running the following:
I built from source at commit 9b8478d - If I run
Please let me know what I can do to help with this issue. |
Interesting that this also fails on the Postgres source code:
|
Great, now that I am able to reproduce I will fix soon. Thanks for reporting. |
External contributions are welcome here! |
The cause of this is skipping certain file deletions as they become binary and go out of sight. They become binary because the current algorithm in Hercules checks for invalid utf-8 which is stricter than simple scanning for |
This is awesome - I will take it for a spin on GPDB as soon as I can. |
I'm trying to run hercules against my repo:
Using (v4 on Windows): https:/src-d/hercules/releases/download/v4/hercules.win64.zip
The text was updated successfully, but these errors were encountered: