Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RUSTFLAGS not prepending whitespace in coverage.rs #100

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix RUSTFLAGS not prepending whitespace in coverage.rs #100

merged 1 commit into from
Oct 1, 2024

Conversation

R9295
Copy link
Collaborator

@R9295 R9295 commented Oct 1, 2024

No description provided.

@R9295 R9295 requested a review from louismerlin October 1, 2024 13:32
@R9295
Copy link
Collaborator Author

R9295 commented Oct 1, 2024 •
edited
Loading

This led to any custom RUSTFLAGS not working unless it was RUSTFLAGS=" xxx" instead of RUSTFLAGS="xxx"

@louismerlin
Copy link
Collaborator

Haha yeah makes sense 🙃

@louismerlin louismerlin merged commit 8d3ad74 into main Oct 1, 2024
8 checks passed
@R9295 R9295 deleted the fix/rustflag_coverage branch October 1, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismerlin louismerlin Awaiting requested review from louismerlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@R9295 @louismerlin