Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v3.0.0 #181

Merged
merged 21 commits into from
Jun 14, 2020
Merged

chore: v3.0.0 #181

merged 21 commits into from
Jun 14, 2020

Conversation

ssut
Copy link
Owner

@ssut ssut commented Jun 9, 2020

Breaking Changes:

  • Drop support for python <=3.5.
  • Replace requests with httpx, which supports HTTP/2, asyncio (TODO in googletrans), and timeout by default.
    • The way handling timeout has been changed by using httpx, it must be handled with httpx.Timeout.

Improvements & Fixes:

Also fixes: #133, #147, #150, #151, #163, #164.

@ssut ssut self-assigned this Jun 9, 2020
@coveralls
Copy link

coveralls commented Jun 9, 2020

Coverage Status

Coverage increased (+1.6%) to 90.98% when pulling c6a4c07 on feature/httpx into 312f36a on master.

@ssut ssut linked an issue Jun 9, 2020 that may be closed by this pull request
@Djailla
Copy link
Contributor

Djailla commented Jun 9, 2020

Sounds really good !

httpx is still considered as beta but worth trying

Copy link
Collaborator

@0mars 0mars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ssut
Copy link
Owner Author

ssut commented Jun 9, 2020

Thanks for reviewing the changes! :)

I will merge this as soon as:

  • Coverage reports pass at least 90%: Working on this.
  • All pending issues labeled: I am checking all opened issues these days, and this will not take a long time.

so please give me some time, thank you.

@0mars
Copy link
Collaborator

0mars commented Jun 9, 2020

@ssut thank you so much, deeply appreciated! :)

@ssut ssut mentioned this pull request Jun 9, 2020
@Insutanto
Copy link

What about this PR?
#142 Support merge bulk translate request
try to fix #76 #74 #85

@ssut
Copy link
Owner Author

ssut commented Jun 10, 2020

Now this PR is ready to be merged for next release! I will review the whole changes again, and release within this week. Thanks.

googletrans/constants.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
tox.ini Show resolved Hide resolved
test-requirements.txt Outdated Show resolved Hide resolved
googletrans/constants.py Outdated Show resolved Hide resolved
googletrans/client.py Outdated Show resolved Hide resolved
@ssut ssut changed the title Possible major release of googletrans (3.0.0) is here chore: v3.0.0 Jun 14, 2020
@ssut ssut merged commit e10c5e8 into master Jun 14, 2020
@ssut ssut deleted the feature/httpx branch June 14, 2020 06:42
@ssut
Copy link
Owner Author

ssut commented Jun 14, 2020

I just released v3.0.0 on pypi: https://pypi.org/project/googletrans/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment