Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that get_items does not recurse #608

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Make sure that get_items does not recurse #608

merged 3 commits into from
Oct 30, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Oct 26, 2023 •
edited
Loading

Related Issue(s):

Description:

Since we were ignoring the recursive argument, you could enter a recursion loop

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pystac_client/client.py 93.28% <100.00%> (+2.68%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

TomAugspurger
TomAugspurger approved these changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the python 3.8/3.9 syntax is fixed.

@jsignell jsignell enabled auto-merge (squash) October 30, 2023 14:12
@jsignell jsignell merged commit df9b213 into stac-utils:main Oct 30, 2023
17 checks passed
@gadomski gadomski mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsignell @codecov-commenter @TomAugspurger