Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CollectionClient.get_items with IDs when recursive=False #639

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

bmcandr
Copy link
Contributor

@bmcandr bmcandr commented Feb 8, 2024

Related Issue(s):

Description:

  • Fixes inconsistent behavior in CollectionClient.get_items when Item IDs are supplied.
  • Adds test_get_items_with_ids to test_collection_client.py.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

* Enable filtering on Item IDs when `recursive=False`
* Add `test_get_items_with_ids` to `test_collection_client.py`
@bmcandr
Copy link
Contributor Author

bmcandr commented Feb 8, 2024

The RTD build looks like it failed due to PC STAC timing out. I encountered similar timeouts while trying to record the cassette for the new test too, but eventually got a successful response. PC STAC seems to be struggling a bit this morning.

@gadomski gadomski linked an issue Feb 8, 2024 that may be closed by this pull request
@gadomski gadomski enabled auto-merge (squash) February 8, 2024 16:00
@gadomski gadomski merged commit 6e49132 into stac-utils:main Feb 8, 2024
18 checks passed
@bmcandr bmcandr deleted the fix/638 branch February 8, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CollectionClient.get_items() *ids argument behavior unclear
2 participants