Don't treat warnings as errors.

[sebastic]

Using -Werror in CI is good, it is not a good default for downstream distributions where new warnings by toolchain updates causes the build to fail.

Importing dateutil.parser causes a DeprecationWarning:

  /usr/lib/python3/dist-packages/dateutil/tz/tz.py:37: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    EPOCH = datetime.datetime.utcfromtimestamp(0)

[gadomski]

-Werror is just for pytest, so shouldn't affect downstream users?

[sebastic]

-Werror is just for pytest, so shouldn't affect downstream users?

The Debian package build runs python3.12 -m pytest in its test target, which causes the build to fail due to -Werror in pyproject.toml.

[gadomski]

Makes sense, but can you add -Werror to the CI test invocation so we still catch warnings in our Github CI?

[sebastic]

Makes sense, but can you add -Werror to the CI test invocation so we still catch warnings in our Github CI?

You already do that:

        run: pytest -Werror -s --block-network --cov pystac_client --cov-report term-missing

https:/stac-utils/pystac-client/blob/main/.github/workflows/continuous-integration.yml#L42

[gadomski]

🙃 thanks! Clearly I'm not on my game this morning ... appreciate it :-).

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21435b0) 93.43% compared to head (c7e1c81) 93.44%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   93.43%   93.44%           
=======================================
  Files          13       13           
  Lines         990      991    +1     
=======================================
+ Hits          925      926    +1     
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.