Pin rustc version to nightly-2021-04-27 in CI #581
Conversation
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 75 75
Lines 10776 10776
Branches 1053 1053
=======================================
Hits 10204 10204
Misses 396 396
Partials 176 176 Continue to review full report at Codecov.
|
When orjson doesn't have a wheel available for a given OS+Python, we have to build it from source during CI. This requires the rust compiler (and associated tooling). There was a minor regression in the output of the `--version` command in one rust tool (`cargo`) which caused the `orjson` build chain to break. When rust-lang/cargo#9727 is incorporated back into nightly Rust releases we can unpin this toolchain and revert it back to `nightly`. The check that was failing because of the regression: https:/PyO3/maturin/blob/5f134e3a4adbbf21f04c10f1dc9722742156f959/maturin/__init__.py#L114-L122
There was a problem hiding this comment.
Thanks for tracking this down @gadomski!
Given that we're only using this until the orjson wheels are more available and the fact that the nightly toolchain is inherently unstable I'm thinking we should just keep this pinned to a specific nightly version. What do you think?
|
I think we should keep it pinned until something breaks again, then update the pin to another nightly that works. Tracking nightly w/o a pin feels like a recipe for intermittent errors. |
Related Issue(s): #577 (comment)
Description: When orjson doesn't have a wheel available for a given OS+Python, we have to build it from source during CI. This requires the rust compiler (and associated tooling). There was a minor regression in the output of the
--versioncommand in one rust tool (cargo) which caused theorjsonbuild chain to break. When rust-lang/cargo#9727 is incorporated back into nightly Rust releases we can unpin this toolchain and revert it back tonightly.The check that was failing because of the regression:
https:/PyO3/maturin/blob/5f134e3a4adbbf21f04c10f1dc9722742156f959/maturin/__init__.py#L114-L122
PR Checklist:
pre-commit run --all-files)scripts/test)[ ] Documentation has been updated to reflect changes, if applicable[ ] This PR maintains or improves overall codebase code coverage.