Upgrade react-scripts to 4.0.0 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes: - added postcss as it's not a dependency of postcss-cli since 8.x - bunch of linting fixes, mostly being more strict with types and avoiding 'any' - added 'assertDefined' utility function as an escape hatch against not strict swagger definitions that don't specify that, say, 'ID' is not an optional property and always present
ikornienko
commented
Dec 4, 2020
| @@ -13,18 +13,40 @@ type Props = { | |||
| onModify?: (notation: string, incOrDec: string) => void; | |||
| }; | |||
|
|
|||
| export default function Countdown({ targetDate, className = '', onModify }: Props): ReactElement { | |||
| const duration = calcDuration(targetDate); | |||
| type ModifiableTimeUnitProps = { | |||
There was a problem hiding this comment.
In this file nothing changed except of the order in which components are defined. Airbnb code style now requires things to be defined before they're used, which is a common practice I've seen across many respectful OSS projects. It's an opinionated thing... yet we agreed before to outsource decisions about opinionated topics to Prettier and Airbnb, so following the suite :)
ikornienko
commented
Dec 4, 2020
| }; | ||
|
|
||
| export default function DownloadArtifactsModal({ cluster, onClose }: Props): ReactElement { |
There was a problem hiding this comment.
Same here, it's just re-ordering of component definitions.
gavin-stackrox
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incremental continuation of effort from #216.
Things to note:
[email protected]because of .eslintcache constantly generated facebook/create-react-app#10161 as VSCode isn't yet friends with ESLint caching feature;postcssas a dev dependency as it's not a dependency ofpostcss-clisince8.x;any;assertDefinedutility function as an escape hatch against not strict swagger definitions that don't specify that, say,IDis not an optional property and always present... not ideal, yet asserting on something that MUST be true feels conceptually right.