-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Why does import require functions on the prototype to be bound to the instance? #797
Comments
DUUUDE @phated! There was a regression in the last release related to detection of handling of CJS exports. A combo of things have slowed down pushing an update (vacation, switching jobs, life stuff). I'm hoping to get back into the rhythm of things soon and cleanup the remaining |
Congrats on the new job. Here's a minimal repro: https:/phated/gulp-esm-issue - should be able to replicate with |
Ah okay! On review of the repro the issue is by design as ESM (the module system not the |
Cool, I thought it might be something like that. I'll be cutting a release that implements the fix on gulp's end. Thanks |
I'm working on some sample code for gulp and found that I can import
series
orparallel
successfully but notsrc
ordest
.Examples:
I've found that is because gulp does the following:
If the following lines are added to the constructor, the imports work successfully:
I'll likely be patching gulp so everything works correctly with esm but I'm just wondering why this issue has occurred.
The text was updated successfully, but these errors were encountered: