Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore workspace/didChangeConfiguration #564

Merged
merged 1 commit into from
May 31, 2023

Conversation

ryansch
Copy link
Contributor

@ryansch ryansch commented May 29, 2023

When using standard with nvim-lspconfig, the server receives a workspace/didChangeConfiguration message immediately after starting.

Standard currently returns an INVALID_SERVER_MESSAGE which causes neovim to display lots of angry errors.

I've added a route to ignore this LSP message while logging that we're doing that.

@searls
Copy link
Contributor

searls commented May 31, 2023

Seems reasonable. I'm 99% sure my VS Code extension is coded to restart the server when the configuration changes, so it doesn't immediately make sense for the LSP to do anything more fancy for its sake, either

@searls searls merged commit e8e4f69 into standardrb:main May 31, 2023
@searls
Copy link
Contributor

searls commented May 31, 2023

Landed in 1.28.5

@ryansch ryansch deleted the didChangeConfiguration branch June 1, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants