Skip to content

Commit

Permalink
azure: Don't override pip's builddir
Browse files Browse the repository at this point in the history
As of 21.3 pip:

> Remove the --build-dir option and aliases, one last time. (pypa/pip#10485)

https://pip.pypa.io/en/stable/news/#v21-3

Previous versions warn about deprecation.

The builddir is provided to pip via env variable PIP_BUILD in Tox task.
The purpose of changing of default builddir was noexec mount option for
/tmp in Travis (see 17d571c). Since Travis is no longer used and
Azure lacks this issue the PIP_BUILD can be safely removed.

Note: pip 21.3 just ignores this env variable, which is more than can be
said for the command line option. It's better to clean it up, since the
behaviour may be changed in future.

Fixes: https://pagure.io/freeipa/issue/9011
Signed-off-by: Stanislav Levin <[email protected]>
  • Loading branch information
stanislavlevin committed Oct 19, 2021
1 parent afc1bf2 commit 5950b47
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .tox-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,6 @@ fi
export PIP_CACHE_DIR="${TOXINIDIR}/.tox/cache"
mkdir -p "${PIP_CACHE_DIR}"

# /tmp could be mounted with noexec option.
# pip checks if path is executable and if not then doesn't set such
# permission bits
export PIP_BUILD="${ENVDIR}/pip_build"
rm -rf "${PIP_BUILD}"

DISTBUNDLE="${TOXINIDIR}/dist/bundle"
mkdir -p "${DISTBUNDLE}"

Expand Down

0 comments on commit 5950b47

Please sign in to comment.