Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify app to support release-script #621

Open
pwilkins opened this issue Mar 25, 2016 · 5 comments
Open

Modify app to support release-script #621

pwilkins opened this issue Mar 25, 2016 · 5 comments

Comments

@pwilkins
Copy link

We ought to use release-script (mitodl/release-script) so that we can use the same release workflow for all out projects. This may be as simple as adding a VERSION attribute to starcellbio/settings.py.

@pdpinch @justinabrahms

@justinabrahms
Copy link
Contributor

👍

@pwilkins
Copy link
Author

I found an additional issue with using release-script here. Starcellbio uses a different git branch scheme than the rest of our projects. Most of our projects use master for their main development branch, starcellbio uses develop. The release-script assumes the main development branch is master.

Rats. This will be harder than I hoped.

@justinabrahms
Copy link
Contributor

We could introduce a file in the root of the repository which is something
like: DEV_BRANCH=develop

We could source that, if it exists. If not use known defaults.

@pdpinch
Copy link
Contributor

pdpinch commented Mar 25, 2016

Somehow GitHub knows what the default branch is -- is that specific to GitHub, or is it a git repo attribute?


I am mobile.

On Mar 25, 2016, at 4:24 PM, Justin Abrahms [email protected] wrote:

We could introduce a file in the root of the repository which is something
like: DEV_BRANCH=develop

We could source that, if it exists. If not use known defaults.

On Fri, Mar 25, 2016 at 4:17 PM, Peter Wilkins [email protected]
wrote:

I found an additional issue with using release-script here. Starcellbio
uses a different git branch scheme than the rest of our projects. Most of
our projects use master for their main development branch, starcellbio
uses develop. The release-script assumes the main development branch is
master.

Rats. This will be harder than I hoped.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#621 (comment)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@justinabrahms
Copy link
Contributor

GitHub iirc. Can probably find it w/ git-fu.

On Friday, March 25, 2016, Peter Pinch [email protected] wrote:

Somehow GitHub knows what the default branch is -- is that specific to
GitHub, or is it a git repo attribute?


I am mobile.

On Mar 25, 2016, at 4:24 PM, Justin Abrahms <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

We could introduce a file in the root of the repository which is
something
like: DEV_BRANCH=develop

We could source that, if it exists. If not use known defaults.

On Fri, Mar 25, 2016 at 4:17 PM, Peter Wilkins <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

I found an additional issue with using release-script here. Starcellbio
uses a different git branch scheme than the rest of our projects. Most
of
our projects use master for their main development branch, starcellbio
uses develop. The release-script assumes the main development branch is
master.

Rats. This will be harder than I hoped.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
<
#621 (comment)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#621 (comment)

Sent via mobile phone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants