[5.x] Merge config field defaults into field config #10139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #10106, where the Code Fieldtype wouldn't retain the selected mode even when the
mode_selectable
config option looked like it was enabled (by default, it's set totrue
).This was happening since the
Code::process()
method saves just the code value and not the mode/language whenmode_selectable
isfalse
:cms/src/Fieldtypes/Code.php
Lines 152 to 154 in 73c48a4
cms/src/Fieldtypes/Code.php
Lines 194 to 197 in 73c48a4
This PR fixes that by ensuring the default values for fieldtype config fields are included in the output of
Fieldtype::config()
.Fixes #10106.