Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix dark mode for Set Picker #10173

Merged
merged 2 commits into from
May 23, 2024

Conversation

martyf
Copy link
Contributor

@martyf martyf commented May 23, 2024

The current Set Picker is not great in Dark Mode:
image

This PR improves Set Picker dark mode:
image

Resolves #10125

@peimn
Copy link
Contributor

peimn commented May 23, 2024

Please refer to the sample and select the appropriate dark shades.

@jackmcdade
Copy link
Member

jackmcdade commented May 23, 2024

Please refer to the sample and select the appropriate dark shades.

What sample are you referring to? This looks pretty solid to me. Right in line with everything else.

@jackmcdade jackmcdade merged commit f10f3be into statamic:5.x May 23, 2024
17 checks passed
@peimn
Copy link
Contributor

peimn commented May 23, 2024

I mean other similar components... However, it is alright if you believe it is correct.

@peimn
Copy link
Contributor

peimn commented May 23, 2024

And I'm the only one banned from adding pull requests to the dark mode! 👀

@jackmcdade
Copy link
Member

You're not banned – you just previously pushed PRs for stuff we already finished.

@peimn
Copy link
Contributor

peimn commented May 23, 2024

#10150 (comment)

@jackmcdade
Copy link
Member

jackmcdade commented May 23, 2024

Fair enough – i was just trying to save you effort because i was just working on dark mode stuff full time. i'm back off now as i already pushed everything i could find – so feel free to PR again! ❤️

@peimn
Copy link
Contributor

peimn commented May 23, 2024

I feel that I've contributed adequately to this update. If there are any additional changes that others may have missed, I'll be sure to push them. I'm planning to focus on other updates.

@jackmcdade
Copy link
Member

@peimn Thank you!

@peimn
Copy link
Contributor

peimn commented May 23, 2024

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dark] Replicator/Bard set picker missing dark UI
3 participants