Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Filter out global set variables associated to deleted sites #10195

Merged
merged 2 commits into from
May 28, 2024
Merged

[5.x] Filter out global set variables associated to deleted sites #10195

merged 2 commits into from
May 28, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request filters out Global Set Variables associated to non-existent sites.

Fixes #10180.

jasonvarga
jasonvarga requested changes May 24, 2024
View reviewed changes
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should do the filtering farther up the chain.

GlobalSet::whereSet() shouldn't give you items that won't ever work.

@jasonvarga jasonvarga merged commit 33a8fc4 into 5.x May 28, 2024
17 checks passed
@jasonvarga jasonvarga deleted the fix/filter-global-set-variables-associated-to-deleted-site branch May 28, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga jasonvarga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting sites should delete content / not error
2 participants
@duncanmcclean @jasonvarga