[5.x] Bring back select param on nav tag #10226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohnathonKoster If you wouldn't mind checking to see that I haven't somehow negated BulkAugmentor5000™'s speed benefits that would be appreciated. |
# Conflicts: # tests/Tags/StructureTagTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #10219 I noticed that the
select=""param on thenavtag doesn't do anything anymore since #9636.Of course that PR made everything faster anyway so the benefits of using
select=""may have been diminished. But, if you still want to select specific fields, that should make things even better. May as well allow it.Edit: People noted in #10503 that they intentionally wanted fields to be missing, so there was a use to it beyond performance.
Closes #10503.