[5.x] Add UI for listing field sortable config #10259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the condition isn't right, it should also be shown when listable is "hidden by default" but then there was issues doing "lisable: not true" and i dont want to go down that rabbit hole. other fields in that settings view are still shown when they arent applicable anyway.
|
Thank you |
duncanmcclean
added a commit
to statamic/docs
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its totally possible I'm being dumb and not noticing it elsewhere, but it seems theres no UI for controlling whether a field is sortable in a listing view (even though there is a config setting for it).
This PR adds a toggle field to the common field options, which is only shown when the field is listable (or hidden by default) and when its not a computed field: