[5.x] Migrate from vue-countable #10287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
previously requested changes
Jun 17, 2024
resources/js/components/fieldtypes/markdown/MarkdownFieldtype.vue
Outdated
Show resolved
Hide resolved
jasonvarga
changed the title
jasonvarga
dismissed
duncanmcclean’s stale review
The diff has been resolved as requested.
jasonvarga
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue countable, which is being used for counting words and characters inside the markdown field (and only fullscreen) has not been updated for a long time: https:/johndatserakis/vue-countable
Other than that, vanilla JS is powerful enough to cover this functionality.
Mainly, this PR will contribute to the upgrade to Vue 3 in the future 🔥