[5.x] Move updating from collection repo to entry repo #10383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
changed the title
1 task
jasonvarga
deleted the
collections-doing-stuff-entries-should-probably-be-doing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing issues where the collection repository is doing stuff that the entries repository should probably be doing. Such as updating entry uris, orders, parents, etc.
The collection code is assuming entries are in the Stache, which - if you use the Eloquent driver for entries but keep collections in the Stache - is incorrect.
statamic/eloquent-driver#260
statamic/eloquent-driver#220