Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Remove container tabs from Asset Manager #10392

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request removes container tabs from the Asset Manager, in favour of navigating between asset containers using the Control Panel navigation.

The asset container tabs were inherited from v2 and we don't really use tabs for navigating between "things" elsewhere, so we thought just removing them would be the easiest option.

By removing the tabs altogether, it means developers can re-order & hide asset containers by using the CP Nav customizer. This saves us needing to build a special way to re-order asset containers, as suggested in #10177.

In addition to removing the tabs, I've also tweaked the "redirect to first container" logic so it takes into the account any re-ordering of asset containers that has taken place in the CP nav customzer.

Closes #10177.
Closes #10285.
Closes statamic/ideas#42.
Closes statamic/ideas#829.
Closes statamic/ideas#924.

duncanmcclean and others added 3 commits July 3, 2024 21:02
Before it redirects you to the first container in alphabetical order, it'll take a look at the "Assets" nav item and redirect to its first child.

This allows you to re-order the asset containers as you wish by using the CP nav customizer.
@jasonvarga jasonvarga merged commit 4495b6d into 5.x Jul 9, 2024
16 checks passed
@jasonvarga jasonvarga deleted the remove-container-tabs-from-asset-manager branch July 9, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants