[5.x] Prevent updating time fieldtype value if it hasn't changed #10409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
deleted the
prevent-updating-time-fieldtype-value-if-it-hasnt-changed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the Time Fieldtype, where its value would end up being saved in the localized entry's data, even when the field wasn't marked as "Localizable" in the blueprint.
This was happening due to the fact the fieldtype was updating the field's value in the publish container, which subsequently added the time field to the
localizedFieldsarray, which is the array that contains the fields that should end up getting saved to the entry's data.To fix this, I've wrapped the "update the value" code in a conditional to check whether the value has actually be changed or not.
No issue, related to support ticket 5742.