[5.x] Prevent double login causing 419 CSRF token mismatch #10465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where some people were seeing 419 errors after logging in.
We found that the reason was typically due to submitting the form twice.
Either by:
It seems that the first time the form is submitted, you get logged in and your csrf token is updated. Then if you click it a second time, the old token is submitted but no longer matches your current one, resulting in the error.
This PR fixes that issue by disabling the submit button while the form is submitting, preventing you from submitting twice.
This PR gives the same treatment to the reset password form which has the same issue.