Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Prevent showing selected items in relationship field dropdown mode with max items 1 #10477

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Jul 18, 2024

When using the entries fieldtype in dropdown mode you see the selected items underneath since #10447.
However, when using max_items: 1, it's redundant since the selected item is in the dropdown itself.

I was going to add the status icon and hint to the selected item in the dropdown but that opened up a bit of a can of CSS worms I don't want to deal with in this PR.

Before:

CleanShot 2024-07-18 at 10 42 14

After:

CleanShot 2024-07-18 at 10 42 31

Closes #10474

@jasonvarga jasonvarga merged commit 15bfbdc into 5.x Jul 18, 2024
17 checks passed
@jasonvarga jasonvarga deleted the relationship-dropdown-max-1 branch July 18, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select dropdown entries showing below field when max_items is 1
1 participant