Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Improve addons listing #10812

Merged
merged 9 commits into from
Sep 19, 2024
Merged

[5.x] Improve addons listing #10812

merged 9 commits into from
Sep 19, 2024

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Sep 18, 2024

This pull request makes various UI improvements to the "Addons" page in the Control Panel. It's still not perfect, but it's way better than what we have right now.

Screenshots

CleanShot 2024-09-18 at 15 23 19

CleanShot 2024-09-18 at 15 23 46

@duncanmcclean duncanmcclean marked this pull request as ready for review September 18, 2024 14:21
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When on a narrow viewport, the description is now above the meta data and is missing margin.

CleanShot 2024-09-18 at 11 24 49

@duncanmcclean
Copy link
Member Author

@jasonvarga Fixed!

@jasonvarga
Copy link
Member

jasonvarga commented Sep 18, 2024

You only fixed the spacing. (Which is great 👌 ) The description is still first. The meta/install cards should go first.

Also, tweak padding inside the metadata cards.
@duncanmcclean
Copy link
Member Author

You only fixed the spacing. (Which is great 👌 ) The description is still first. The meta/install cards should go first.

Ohhh.... that should be fixed now too 😅

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jasonvarga jasonvarga merged commit be249c2 into 5.x Sep 19, 2024
16 checks passed
@jasonvarga jasonvarga deleted the improve-addons-listing branch September 19, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants