[5.x] Remove Str call forwarding for 🌶️ methods
#9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnathonKoster
changed the title
Str call forwarding for 🌶️ methodsStr call forwarding for 🌶️ methods
37 tasks
|
I can't see any places where |
No, you're correct 🙈 (likely over-aggressive copy/pasta on my part). That one can be removed for now; I can update this PR later today 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following string helpers into the
Statamic\Support\Strclass to prevent them being called via. dynamic calls or forwarding to Stringy:These functions are used in hot code paths and the forwarding overhead is not insignificant when working with many, many thousands of entries/etc.