Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add missing french translations #10032

Merged
merged 2 commits into from
May 10, 2024

Conversation

PatrickJunod
Copy link
Contributor

  • Add missing french translations for sites configuration
  • Reorder translations to match the english translation file

Note

Note on translations: Locale and Language are not the same and in my opinion, this line should be called "Language" instead of "Locale":

'display' => __('Locale'),

In my proposed translation file, I changed the "Local" key. Using "locale" instead of "langue"as it is a better translation.
As a side effect it will also change the label in the user preferences from Langue to Locale which can be "ok" but not enough precise.

What could be done:

  • Change the CorePreferences display label to __('Language')
  • Add the missing translations in all languages

@jasonvarga
Copy link
Member

Note on translations: Locale and Language are not the same and in my opinion, this line should be called "Language" instead of "Locale":

We call it locale as it maps to the configuration variable from Laravel itself.

See: https:/laravel/laravel/blob/b3df041d860233e3d1cd325fea41abe6564e894c/config/app.php#L81

@jasonvarga jasonvarga merged commit c256e9d into statamic:5.x May 10, 2024
16 checks passed
@ebeauchamps
Copy link
Contributor

ebeauchamps commented May 13, 2024

@PatrickJunod
Locale isn't a French word. Should not remain as it.
I am not very kind on translating Fieldtype title either. Make it difficult to link to documentation

@jasonvarga
Copy link
Member

You two may debate the French usage and then open a PR with the appropriate translation. 😄 I was just explaining why we use the word "Locale" instead of "Language".

@PatrickJunod
Copy link
Contributor Author

@PatrickJunod Locale isn't a French word. Should not remain as it. I am not very kind on translating Fieldtype title either. Make it difficult to link to documentation

Concerning the Locale word - we could then maybe use "Paramètres régionaux" instead. I'll open a PR for that then ;-)

@ebeauchamps
Copy link
Contributor

@PatrickJunod Locale isn't a French word. Should not remain as it. I am not very kind on translating Fieldtype title either. Make it difficult to link to documentation

Concerning the Locale word - we could then maybe use "Paramètres régionaux" instead. I'll open a PR for that then ;-

@PatrickJunod
J'ai traduit Locale par Langue depuis la version 1. C'est la langue du site ou la langue de l'entrée sur un multisites multilingues. Ils ont ajouté Language dans un autre contexte, mais cela reste la Langue aussi. Si on met "Paramètres régionaux" (au pluriel ??) à chaque fois que l'utilisateur va devoir traduire une entrée, cela va être incompréhensible à mon sens.

@PatrickJunod PatrickJunod deleted the fix/missing-french-translations branch August 16, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants