[5.x] Fix cursor on Select fieldtype when max_items has been reached
#10442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favour of #10457. |
duncanmcclean
deleted the
fix/cursor-on-select-fieldtype-when-max-items-has-been-reached
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue on the Select fieldtype where a
not-allowedcursor would be shown on selected options when themax_itemssetting has been reached.To fix this, I've added an additional class to the
v-selectcomponent when themax_itemssetting has been reached, which will be used to determine if thenot-allowedcursor should be applied to selected options. Maybe there's a better way of fixing this?Fixes #10431.