[5.x] Improve duplicate asset upload handling #10959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wkward in this pr
it was working fine, but working on another part gave me doubts.
…r the top of it ... not a great solution but it seems to work
… its a large file dont offer to reupload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the UX regarding file uploads in the assets section, the assets fieldtype, and the asset browser within the fieldtype.
You will now be presented with various options when uploading a file that already exists at the destination path.
The same behavior as the "reupload asset" action. The file will be replaced. Data (alt text, etc) will remain the same.
A modal will open to allow you to enter a new filename. Essentially the same as renaming the file on your computer and reuploading.
This is the current behavior. The file will be uploaded with a timestamp appended.
When used in an asset fieldtype or the selector stack, this will discard your upload and instead select the existing asset.
This PR also prevents you from renaming assets to ones that already exist. You will now get a validation error. The error will guide you on a more appropriate option based on whether the file seems to be identical.
In the future we might be able to make the suggestion actionable from there, but at the moment it would likely require big changes to how actions work.
Closes statamic/ideas#401
Fixes #8027