Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] filter_empty modifier #10962

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[5.x] filter_empty modifier #10962

merged 2 commits into from
Oct 16, 2024

Conversation

marcorieser
Copy link
Contributor

@marcorieser marcorieser commented Oct 15, 2024 •
edited
Loading

It adds a filter modifier that removes null values from an array. It accepts a param on whether to keep or discard the array's keys (default: true/keep).

@marcorieser marcorieser changed the title add filter modifier [5.x] filter modifier Oct 15, 2024
@marcorieser marcorieser mentioned this pull request Oct 15, 2024
Open
@jasonvarga
Copy link
Member

Competing with #10961 @godismyjudge95 🥊

@jasonvarga jasonvarga mentioned this pull request Oct 15, 2024
Closed
@jasonvarga
Copy link
Member

Calling this filter_empty to keep filter available if we ever want to support the full scope of filter.

Also, removed the option to remove keys. If you want to do that you can use the values modifier already.

@jasonvarga jasonvarga merged commit 9745141 into statamic:5.x Oct 16, 2024
16 checks passed
@marcorieser marcorieser deleted the filter-modifier branch October 16, 2024 14:21
@marcorieser marcorieser changed the title [5.x] filter modifier [5.x] filter_empty modifier Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcorieser @jasonvarga