Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count published entries only for entries_count #7489

Closed

Conversation

arthurperton
Copy link
Contributor

@arthurperton arthurperton commented Feb 7, 2023

Fixes #3539.

@what-the-diff
Copy link

what-the-diff bot commented Feb 7, 2023

  • Added a new index to the Associations Index
  • Updated TermRepository::entriesCount() and TaxonomyTermsStore::sync() methods to filter by status when counting entries for a term
  • Fixed tests in TermEntriesTest that were failing due to changes made in First #1 & Pagination #2 above

@arthurperton arthurperton marked this pull request as ready for review February 7, 2023 17:25
@arthurperton arthurperton marked this pull request as draft February 7, 2023 17:27
@arthurperton arthurperton marked this pull request as ready for review February 7, 2023 17:29
@arthurperton
Copy link
Contributor Author

Weird. I had all kinds of (seemingly unrelated) tests failing and now after merging in 3.4 all troubles are gone. Ready for review I guess 😄.

@jasonvarga
Copy link
Member

I agree this needs to be fixed but I don't think this is it.

The count of entries should include entries of any status, similar to in #7334 how we include drafts in the cp. If we were to use entries_count in the cp somewhere for example, we'd want to include the drafts.

With this solution, the drafts are always filtered out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entries_count includes published and unpublished entries
2 participants