[5.x] Update our custom string based rules to class based rules #9785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation rule changes
As an extension to #9778 and #9780, this PR refactors our old custom validation rule classes in the
Statamic\Validation
namespace, to proper LaravelValidationRule
implementations withinStatamic\Rules
, and also removes string basedValidation builder changes
As for the custom rules we had defined in our old ValidationServiceProvider, we now explicitly define which custom rules get added to the validation builder in our
Rules.js
object:It makes sense for people to add extra unique validation rules in their own blueprints, but we don't think it ever made sense for
unique_form_handle
orcode_fieldtype_rulers
to appear in the builder UI, so these will no longer show 👌Todo
ClassRuleParser
andFields\Validator
to properly handle{collection}
style replacementsnull
valuestrue
/false
booleansUniqueEntryValue
ruleUniqueTermValue
ruleUniqueUserValue
ruleUniqueFormHandle
ruleCodeFieldtypeRulers
rule