Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix issues with PreventsSavingStacheItemsToDisk trait #9874

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Apr 12, 2024

This pull request fixes some issues I introduced in my previous PR, #9871:

  • After testing with the Eloquent Driver, I realised that it was creating the temporary files in paths like this: tests/__fixtures__/dev-null/Users/duncan/Code/Statamic/eloquent-driver/vendor/orchestra/testbench-core/laravel/content/collections instead of simply tests/__fixtures__/content/collections
    • This was only happening for addons, so I refactored the path replacement logic in the trait and configured the default Stache directories in the AddonTestCase
  • After running the tests, the tearDown method is supposed to delete the temporary Stache files. However, after I renamed the PreventsSavingStacheItemsToDisk trait in c0d5f1f, it stopped doing that.

@duncanmcclean duncanmcclean changed the title Fix/prevents saving stache items to disk trait [5.x] Fix issues with PreventsSavingStacheItemsToDisk trait Apr 12, 2024
@jasonvarga jasonvarga merged commit ebdebd1 into master Apr 12, 2024
33 of 34 checks passed
@jasonvarga jasonvarga deleted the fix/prevents-saving-stache-items-to-disk-trait branch April 12, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants