Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable sound effects #96

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request makes it possible to disable the "door open and door close" sound effects when users join/leave rooms.

This PR adds a new collaboration config file which will be automatically published upon install by Statamic's AddonServiceProvider. The setting defaults to true.

Closes #63.

@jasonvarga jasonvarga merged commit 8e1a634 into master Mar 22, 2024
@jasonvarga jasonvarga deleted the ability-to-disable-sound-effects branch March 22, 2024 20:12
duncanmcclean added a commit that referenced this pull request Mar 25, 2024
duncanmcclean added a commit that referenced this pull request Apr 15, 2024
* Update installation docs

* Bump vite from 4.3.9 to 4.5.2 (#93)

Bumps [vite](https:/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https:/vitejs/vite/releases)
- [Changelog](https:/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https:/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Ability to disable sound effects (#96)

* Sound effects should be enabled by default.

* Document the config option to disable sound effects

Related: #96

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable sound effects
2 participants