Fix querying statuses #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When building the status stuff in core, I was thinking that Eloquent driver extended that. I didn't realize we would need to copy over I'm making a PR into core to extract it into a trait that'll make this PR much leaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue I ran into this morning when using the REST API alongside the Eloquent Driver.
Essentially, when the REST API queries to get entries, it filters for entries where
statusispublished. However, when using the Eloquent Driver, no entries were being returned.I've fixed this issue by copying over the recent changes around entry statuses to the Eloquent Driver (related: #9317).
The implementation is mostly the same as it is in Core. However, the main difference is the fact the Eloquent Driver's query builder doesn't maintain a
$collectionsproperty to track the queried collection, instead we're just using$this->wheres()To Do