Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Single Threaded errors and Memory Leak #266

Merged
merged 9 commits into from
Apr 21, 2024
Merged

Fix Single Threaded errors and Memory Leak #266

merged 9 commits into from
Apr 21, 2024

Conversation

paulov-t
Copy link
Contributor

@paulov-t paulov-t commented Apr 18, 2024 •
edited
Loading

  • Rearrange / refactor components so that the correct components are created in the correct order
  • Remove string usage on processing which causes Memory Leak
  • Fix issue where "Single threaded" errors were occurring when using Development Mode, this may have been causing hidden errors on normal mode too?

TODO: This creates a breaking change for some replication items:

(found so far)

  • GameTimer
  • Armored Train
  • Interact with Container
  • Pong packet from the Server on Relay

These can be handled in separate PRs.

ArchangelWTF
ArchangelWTF reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ArchangelWTF ArchangelWTF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, also happy to finally see some of the commented out blocks disappearing (Some of which have been there for quite some time now)

Source/Coop/Components/CoopGameComponents/SITGameComponent.cs Outdated Show resolved Hide resolved
Source/Networking/GameClient.cs Show resolved Hide resolved
belettee
belettee reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@belettee belettee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the massive cleanup! <3
Unsure about making SITGameServerClientDataProcessing non-static.
What part is fixing the memory leak?

Source/Networking/SITGameServerClientDataProcessing.cs Show resolved Hide resolved
@paulov-t
Copy link
Contributor Author

Thank you for the massive cleanup! <3 Unsure about making SITGameServerClientDataProcessing non-static. What part is fixing the memory leak?

AkiBackendCommunication. Remove the string handling and there is a significant difference in amount of memory used. Found this out about a month ago but it requires so much refactoring to resolve it fully.

@paulov-t paulov-t marked this pull request as draft April 19, 2024 08:24
@paulov-t paulov-t force-pushed the refactor/fix-single-threaded-errors-and-mem-leak branch from c3dfd27 to a3bea45 Compare April 19, 2024 18:13
@paulov-t paulov-t marked this pull request as ready for review April 19, 2024 23:29
belettee
belettee approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@belettee belettee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulov-t paulov-t merged commit a424fb7 into development Apr 21, 2024
@paulov-t paulov-t deleted the refactor/fix-single-threaded-errors-and-mem-leak branch May 17, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArchangelWTF ArchangelWTF ArchangelWTF left review comments

@mihaicm93 mihaicm93 mihaicm93 approved these changes

@belettee belettee belettee approved these changes

@devbence devbence Awaiting requested review from devbence

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulov-t @ArchangelWTF @mihaicm93 @belettee