fix: extraLabels in helm chart not working

steadybit · Aug 10, 2023 · e8d8707 · e8d8707
1 parent 7837d6d
commit e8d8707
Show file tree

Hide file tree

Showing 4 changed files with 69 additions and 2 deletions.
diff --git a/charts/steadybit-extension-gatling/Chart.yaml b/charts/steadybit-extension-gatling/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 name: steadybit-extension-gatling
 description: Steadybit gatling extension Helm chart for Kubernetes.
-version: 1.0.5
+version: 1.0.6
 appVersion: latest
 home: https://www.steadybit.com/
 icon: https://steadybit-website-assets.s3.amazonaws.com/logo-symbol-transparent.png

diff --git a/charts/steadybit-extension-gatling/templates/deployment.yaml b/charts/steadybit-extension-gatling/templates/deployment.yaml
@@ -7,7 +7,7 @@ metadata:
  {{- range $key, $value := .Values.extraLabels }}
  {{ $key }}: {{ $value }}
  {{- end }}
- {{- include "extensionlib.labels" (list .) | nindent 6 }}
+ {{- include "extensionlib.labels" (list .) | nindent 4 }}
 spec:
  replicas: 1
  selector:

diff --git a/charts/steadybit-extension-gatling/tests/__snapshot__/deployment_test.yaml.snap b/charts/steadybit-extension-gatling/tests/__snapshot__/deployment_test.yaml.snap
@@ -198,6 +198,67 @@ manifest should match snapshot with extra env vars:
  name: tmp-dir
  - emptyDir: {}
  name: gatling-target-dir
+manifest should match snapshot with extra labels:
+ 1: |
+ apiVersion: apps/v1
+ kind: Deployment
+ metadata:
+ labels:
+ steadybit.com/discovery-disabled: "true"
+ tags.datadoghq.com/service: steadybit-extension
+ name: RELEASE-NAME-steadybit-extension-gatling
+ namespace: NAMESPACE
+ spec:
+ replicas: 1
+ selector:
+ matchLabels:
+ app.kubernetes.io/name: steadybit-extension-gatling
+ template:
+ metadata:
+ annotations: null
+ labels:
+ app.kubernetes.io/name: steadybit-extension-gatling
+ steadybit.com/discovery-disabled: "true"
+ spec:
+ containers:
+ - env:
+ - name: STEADYBIT_LOG_LEVEL
+ value: INFO
+ - name: STEADYBIT_LOG_FORMAT
+ value: text
+ image: ghcr.io/steadybit/extension-gatling:latest
+ imagePullPolicy: Always
+ livenessProbe:
+ httpGet:
+ path: /health/liveness
+ port: 8088
+ name: extension
+ readinessProbe:
+ httpGet:
+ path: /health/readiness
+ port: 8088
+ resources:
+ limits:
+ cpu: 500m
+ memory: 512Mi
+ requests:
+ cpu: 50m
+ memory: 64Mi
+ securityContext:
+ readOnlyRootFilesystem: true
+ runAsGroup: 10000
+ runAsNonRoot: true
+ runAsUser: 10000
+ volumeMounts:
+ - mountPath: /tmp
+ name: tmp-dir
+ - mountPath: /opt/gatling/target
+ name: gatling-target-dir
+ volumes:
+ - emptyDir: {}
+ name: tmp-dir
+ - emptyDir: {}
+ name: gatling-target-dir
 manifest should match snapshot with mutual TLS:
  1: |
  apiVersion: apps/v1

diff --git a/charts/steadybit-extension-gatling/tests/deployment_test.yaml b/charts/steadybit-extension-gatling/tests/deployment_test.yaml
@@ -60,3 +60,9 @@ tests:
  name: env-secrets
  asserts:
  - matchSnapshot: {}
+ - it: manifest should match snapshot with extra labels
+ set:
+ extraLabels:
+ tags.datadoghq.com/service: steadybit-extension
+ asserts:
+ - matchSnapshot: {}