Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported flow-bin versions #84

Open
vadirn opened this issue Apr 19, 2017 · 3 comments
Open

Supported flow-bin versions #84

vadirn opened this issue Apr 19, 2017 · 3 comments

Comments

@vadirn
Copy link

vadirn commented Apr 19, 2017

I tried a number of different versions of flow and the latest one that seem to work with the plugin is 0.37.0.

Flow installed via brew doesn't seem to work too. It always times out with this message: linter-registry.js [sm]:137 [Linter] Error running Flow IDE Error: Process execution timed out(…)

Activity Monitor shows a number of active "flow" processes.

Is there any restrictions on what version of flow to use? Am I missing something?

@vadirn
Copy link
Author

vadirn commented Apr 19, 2017

My bad, turns out it was related to slow merging inference (facebook/flow#1570)

Removing all // @flow statements helped, though I don't know the exact reason for slow merging inference.

@steelbrain
Copy link
Owner

Hi @vadirn

It's really unfortunate that you had to remove the flow pragma to make Flowjs usable again. By default we set a 60 seconds timeout on flow bin execution. Sometimes as you experience it takes more time than 60 seconds. In that kinda cases, I recommend you be patient and ignore the error because the error is resolved if you save the file once again and let it re-check flow for errors.

Because flow server has most likely processed the file by the time you invoke it the second time, you will most likely get the results correctly, or if not, then definitely on third attempt.

I could increase the maximum timeout and maybe double it but I personally believe that 60 seconds is a fair time for a program to execute itself in, if it doesn't respond during that time it should be killed and respawned.

Let me know what you think

@vadirn
Copy link
Author

vadirn commented Apr 20, 2017

60 seconds should be more than enough, you are right. Thanks for the workaround instructions 👍 Maybe it is a good idea to put these in Readme.

I tried to run flow manually and merging phase never finished. So some of my code constructions caused this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants