Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow-IDE running on files that aren't flow typed #95

Open
eranimo opened this issue Jun 5, 2017 · 4 comments
Open

Flow-IDE running on files that aren't flow typed #95

eranimo opened this issue Jun 5, 2017 · 4 comments
Labels

Comments

@eranimo
Copy link

eranimo commented Jun 5, 2017

Why does Flow-IDE run on files that aren't flow typed? It's a huge waste.

@steelbrain
Copy link
Owner

Flow IDE does not run on non-flow files, it only tries to autocomplete, and that too only if a .flowconfig exists.

If this is not the behavior you're saying, please let us know

@eranimo
Copy link
Author

eranimo commented Jun 5, 2017

What's the point in autocompleting in a file that isn't flow typed? Is there a way to turn that off? I have a 5000 line file that doesn't have any flow typings. It takes ~3 seconds to run Flow-IDE every time I save.

@steelbrain
Copy link
Owner

It's a feature that doesn't slow down your pc or anything and is near-instant. I don't see why you would want to disable it.

If it does not have flow pragma, it should not run flow on it at all. Regardless of the lines in the file, even if it does run it should be near-instant. (unless the file is a base types file and it's types are used in other files).

Can you create a minimal piece of code that reproduces the behavior? That would help a lot

@mcous
Copy link

mcous commented Dec 13, 2017

I'm seeing Flow IDE Coverage warnings on non-Flow files in a Flow project (i.e. .flowconfig exists, but some files do not have the @flow pragma). Is this expected behavior?

Weirdly enough, other things like type on hover are also happening in the non-flow files, but only on certain things. For example, I'm not seeing type annotations on normal variables, but I am seeing them on JSX components. Happy to follow up with more details, but as for the basics:

  • macOS v10.12.6
  • atom v1.23.0
  • atom-ide-ui v0.7.0
  • flow-ide v1.9.0
  • Non-flow files are unit tests for Jest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants