Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for AMD first, then CJS in the UMD #246

Open
stefcameron opened this issue Nov 5, 2016 · 0 comments
Open

Look for AMD first, then CJS in the UMD #246

stefcameron opened this issue Nov 5, 2016 · 0 comments

Comments

@stefcameron
Copy link

Trying es6-promise 4.0.5. Unfortunately, I have an AMD project (packaged with requirejs) that includes es-promise, but changes in the es6-promise build since 3.3.0 has introduced a new UMD which checks for a CommonJS env first unlike the old UMD which used to check for an AMD env first. The result is I can't run my library on NodeJS (like I could before) because es6-promise finds the CommonJS env first and exports itself as a CJS module instead of defining itself as an AMD module.

Unless there's a specific reason why the UMD test order was changed, it might be good to change it back. Otherwise, 3.2.1 is the latest release this type of project could use, AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant