Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies to latest versions #23

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

Joy-Adah
Copy link
Contributor

This PR resolves #2

  • Updated @stellar/stellar-sdk to v12.3.0
  • Updated @stellar/wallet-sdk to v0.11.2
  • Migrated project to Node v20

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, @Joy-Adah! 🎉

Left a couple of bits of feedback, mostly on how some imports have changed in the more recent versions of the SDK.

Thanks again!

src/lib/stellar/horizonQueries.js Outdated Show resolved Hide resolved
src/lib/stellar/transactions.js Outdated Show resolved Hide resolved
src/lib/stellar/sep1.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty great! Couple small changes, and then I think this'll be ready to go.

Thanks!

package-lock.json Outdated Show resolved Hide resolved
src/lib/stellar/sep10.js Outdated Show resolved Hide resolved
@Joy-Adah
Copy link
Contributor Author

Joy-Adah commented Oct 7, 2024

Hey @ElliotFriend I've effected the requested changes!

1 similar comment
@Joy-Adah
Copy link
Contributor Author

Joy-Adah commented Oct 7, 2024

Hey @ElliotFriend I've effected the requested changes!

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Really helpful to have this taken care of!!

✨ Thanks so much for the hard work! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all dependencies
2 participants