[ANCHOR-591] Add clients config to sep10 auth configuration #347
Conversation
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
| # Optional The URL of the client's callback API endpoint | ||
| callback_url: https://callback.client0.com/api/v1/anchor/callback | ||
| # Optional. Default to false. If set to true, allows any destination for deposits. | ||
| allow_any_destination: false |
There was a problem hiding this comment.
Can you note that this 2 fields are ONLY for custodial
| SEP10_REQUIRE_KNOWN_OMNIBUS_ACCOUNT=true | ||
| SEP10_OMNIBUS_ACCOUNT_LIST=GBIBMZNXMD3P7HXVQCYIWWT5NG43NEIIY7VYBQ5SADV6UULUKCAJTGPG | ||
| ```yaml | ||
| clients: |
There was a problem hiding this comment.
Can you have 2 examples of custodial and non custodial separated a bit and add more comments to it (e.g. list fields that are required and optional for custodial/noncustodial)
|
Preview is available here: |
|
Preview is available here: |
| @@ -32,7 +32,8 @@ You should use the `sub` field of the JWT token. For custodial wallets, this val | |||
|
|
|||
| ### How to identify the wallet? | |||
|
|
|||
| You should use a combination of `sub` and `data.client_domain` fields of the JWT token. For custodial wallets, the `sub` value will be in the format `account:memo`. Use the account to identify the wallet. For noncustodial wallets, use the `data.client_domain` field. Note that the wallet must provide the `client_domain` beforehand as a part of SEP-10 authentication. | |||
| giYou should use a combination of `sub` and `data.client_domain` fields of the JWT token. For custodial wallets, the `sub` value will be in the format `account:memo`. Use the account to identify the wallet. For noncustodial wallets, use the `data.client_domain` field. Note that the wallet must provide the `client_domain` beforehand as a part of SEP-10 authentication. If [clients] configuration is present, the `data.client_name` field will also be included in the JWT token, which can be used to identify the wallet. | |||
There was a problem hiding this comment.
This documentation seems to be outdated. I think our current recommendation should be to just use clients
|
LGTM except one small comment |
|
Preview is available here: |
SEP10_CLIENT_ATTRIBUTION_ALLOWLISTSEP10_REQUIRE_KNOWN_OMNIBUS_ACCOUNTSEP10_OMNIBUS_ACCOUNT_LISTclientsconfig and example