-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Drag Handle #361
Updated Drag Handle #361
Conversation
@NiclasDev63 is attempting to deploy a commit to the Elegance Team on Vercel. A member of the Team first needs to authorize it. |
lgtm |
We can also reuse your extensions from npm. I find it better when we have composable extensions instead of being handled by library core. (this approach is similar to shadcn-ui components. Let me know if you think that we can reuse your extensions. Looks like your drag extension can also help with If they can be used, I would recommend the following changes to the PR:
Great work💪 |
I tested locally using my npm packages instead of integrating the code directly into novel core and everything worked as expected. Yes, my extension also solves #341, at least partially, as the scroll speed cannot be configured yet, but auto scrolling works. I'm just not sure at the moment how the docs should be changed regarding the "show a drag and drop configuration" point. It would be good if you could explain this further. |
Hey, related to the scroll speed, it's fine for now as long as the user can disable the autoscroll feature. Related to docs I had in mind something similar to: This would have a step by step structure to configure the drag and drop. The content for it can look like this:
Let me know wdyt about this. I can also help with the docs. |
Thanks, I'll try to add the documentation for the drag handle in the near future. |
Yep that was the thing, just a config for your extension not the html native behaviour.
Could you please update the PR to add your extension packages, and remove the current drag and drop extension code from novel. We can add docs later. |
…sion added as dependency instead. Also added documentation for the new drag handle and auto joiner extensions
b317be4
to
7a248c8
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@radix-ui/[email protected], npm/@tailwindcss/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
I just deleted the drag handle code from novel core and used my npm packages instead. I also added the documentation for both extensions. |
@@ -38,7 +40,10 @@ const simpleExtensions = [ | |||
transformCopiedText: true, | |||
}), | |||
CustomKeymap, | |||
DragAndDrop, | |||
GlobalDragHandle.configure({ | |||
scrollTreshold: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.11.30` -> `20.12.2`](https://renovatebot.com/diffs/npm/@types%2fnode/20.11.30/20.12.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fnode/20.12.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fnode/20.12.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fnode/20.11.30/20.12.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fnode/20.11.30/20.12.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | [`18.2.70` -> `18.2.73`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.70/18.2.73) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact/18.2.73?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact/18.2.73?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact/18.2.70/18.2.73?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact/18.2.70/18.2.73?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@types/react-dom](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-dom) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom)) | [`18.2.22` -> `18.2.23`](https://renovatebot.com/diffs/npm/@types%2freact-dom/18.2.22/18.2.23) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact-dom/18.2.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact-dom/18.2.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact-dom/18.2.22/18.2.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact-dom/18.2.22/18.2.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [ai](https://sdk.vercel.ai/docs) ([source](https://togithub.com/vercel/ai)) | [`3.0.13` -> `3.0.16`](https://renovatebot.com/diffs/npm/ai/3.0.13/3.0.16) | [![age](https://developer.mend.io/api/mc/badges/age/npm/ai/3.0.16?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ai/3.0.16?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ai/3.0.13/3.0.16?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ai/3.0.13/3.0.16?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [novel](https://novel.sh) ([source](https://togithub.com/steven-tey/novel)) | [`^0.2.0` -> `^0.3.0`](https://renovatebot.com/diffs/npm/novel/0.2.13/0.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/novel/0.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/novel/0.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/novel/0.2.13/0.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/novel/0.2.13/0.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [openai](https://togithub.com/openai/openai-python) | `1.14.2` -> `1.14.3` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/openai/1.14.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/openai/1.14.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/openai/1.14.2/1.14.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/openai/1.14.2/1.14.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [openai](https://togithub.com/openai/openai-node) | [`4.29.2` -> `4.31.0`](https://renovatebot.com/diffs/npm/openai/4.29.2/4.31.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/openai/4.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/openai/4.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/openai/4.29.2/4.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/openai/4.29.2/4.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [tailwindcss](https://tailwindcss.com) ([source](https://togithub.com/tailwindlabs/tailwindcss)) | [`3.4.1` -> `3.4.3`](https://renovatebot.com/diffs/npm/tailwindcss/3.4.1/3.4.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/tailwindcss/3.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/tailwindcss/3.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/tailwindcss/3.4.1/3.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/tailwindcss/3.4.1/3.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/ai (ai)</summary> ### [`v3.0.16`](https://togithub.com/vercel/ai/releases/tag/ai%403.0.16) [Compare Source](https://togithub.com/vercel/ai/compare/[email protected]@3.0.16) ##### Patch Changes - [`a54ea77`](https://togithub.com/vercel/ai/commit/a54ea77): feat(ai/rsc): add `useStreamableValue` ### [`v3.0.15`](https://togithub.com/vercel/ai/releases/tag/ai%403.0.15) [Compare Source](https://togithub.com/vercel/ai/compare/[email protected]@3.0.15) ##### Patch Changes - [`4aed2a5`](https://togithub.com/vercel/ai/commit/4aed2a5): Add JSDoc comments for ai/core functions. - [`cf8d12f`](https://togithub.com/vercel/ai/commit/cf8d12f): Export experimental language model specification under `ai/spec`. ### [`v3.0.14`](https://togithub.com/vercel/ai/releases/tag/ai%403.0.14) [Compare Source](https://togithub.com/vercel/ai/compare/[email protected]@3.0.14) ##### Patch Changes - [`8088de8`](https://togithub.com/vercel/ai/commit/8088de8): fix(ai/rsc): improve typings for `StreamableValue` - [`20007b9`](https://togithub.com/vercel/ai/commit/20007b9): feat(ai/rsc): support string diff and patch in streamable value - [`6039460`](https://togithub.com/vercel/ai/commit/6039460): Support Bedrock Anthropic Stream for Messages API. - [`e83bfe3`](https://togithub.com/vercel/ai/commit/e83bfe3): Added experimental ai/core functions (streamText, generateText, streamObject, generateObject). Add OpenAI and Mistral language model providers. </details> <details> <summary>steven-tey/novel (novel)</summary> ### [`v0.3.1`](https://togithub.com/steven-tey/novel/releases/tag/novel%400.3.1) [Compare Source](https://togithub.com/steven-tey/novel/compare/[email protected]@0.3.1) - Fix regression [#​363](https://togithub.com/steven-tey/novel/issues/363) **Full Changelog**: https:/steven-tey/novel/compare/[email protected]@0.3.1 ### [`v0.3.0`](https://togithub.com/steven-tey/novel/releases/tag/novel%400.3.0) [Compare Source](https://togithub.com/steven-tey/novel/compare/[email protected]@0.3.0) #### What's Changed - fix(docs): tailwind extensions guide by [@​arielweinberger](https://togithub.com/arielweinberger) in [https:/steven-tey/novel/pull/354](https://togithub.com/steven-tey/novel/pull/354) - feat: support for custom OpenAI base url by [@​xyspg](https://togithub.com/xyspg) in [https:/steven-tey/novel/pull/358](https://togithub.com/steven-tey/novel/pull/358) - Updated Drag Handle by [@​NiclasDev63](https://togithub.com/NiclasDev63) in [https:/steven-tey/novel/pull/361](https://togithub.com/steven-tey/novel/pull/361) #### New Contributors - [@​arielweinberger](https://togithub.com/arielweinberger) made their first contribution in [https:/steven-tey/novel/pull/354](https://togithub.com/steven-tey/novel/pull/354) - [@​xyspg](https://togithub.com/xyspg) made their first contribution in [https:/steven-tey/novel/pull/358](https://togithub.com/steven-tey/novel/pull/358) - [@​NiclasDev63](https://togithub.com/NiclasDev63) made their first contribution in [https:/steven-tey/novel/pull/361](https://togithub.com/steven-tey/novel/pull/361) **Full Changelog**: https:/steven-tey/novel/compare/[email protected]@0.3.0 </details> <details> <summary>openai/openai-python (openai)</summary> ### [`v1.14.3`](https://togithub.com/openai/openai-python/blob/HEAD/CHANGELOG.md#1143-2024-03-25) [Compare Source](https://togithub.com/openai/openai-python/compare/v1.14.2...v1.14.3) Full Changelog: [v1.14.2...v1.14.3](https://togithub.com/openai/openai-python/compare/v1.14.2...v1.14.3) ##### Bug Fixes - revert regression with 3.7 support ([#​1269](https://togithub.com/openai/openai-python/issues/1269)) ([37aed56](https://togithub.com/openai/openai-python/commit/37aed564143dc7281f1eaa6ab64ec5ca334cf25e)) ##### Chores - **internal:** construct error properties instead of using the raw response ([#​1257](https://togithub.com/openai/openai-python/issues/1257)) ([11dce5c](https://togithub.com/openai/openai-python/commit/11dce5c66395722b245f5d5461ce379ca7b939e4)) - **internal:** formatting change ([#​1258](https://togithub.com/openai/openai-python/issues/1258)) ([b907dd7](https://togithub.com/openai/openai-python/commit/b907dd7dcae895e4209559da061d0991a8d640a6)) - **internal:** loosen input type for util function ([#​1250](https://togithub.com/openai/openai-python/issues/1250)) ([fc8b4c3](https://togithub.com/openai/openai-python/commit/fc8b4c37dc91dfcc0535c19236092992171784a0)) ##### Documentation - **contributing:** fix typo ([#​1264](https://togithub.com/openai/openai-python/issues/1264)) ([835cb9b](https://togithub.com/openai/openai-python/commit/835cb9b2f92e2aa3329545b4677865dcd4fd00f0)) - **readme:** consistent use of sentence case in headings ([#​1255](https://togithub.com/openai/openai-python/issues/1255)) ([519f371](https://togithub.com/openai/openai-python/commit/519f371af779b5fa353292ff5a2d3332afe0987e)) - **readme:** document how to make undocumented requests ([#​1256](https://togithub.com/openai/openai-python/issues/1256)) ([5887858](https://togithub.com/openai/openai-python/commit/5887858a7b649dfde5b733ef01e5cffcf953b2a7)) </details> <details> <summary>openai/openai-node (openai)</summary> ### [`v4.31.0`](https://togithub.com/openai/openai-node/blob/HEAD/CHANGELOG.md#4310-2024-03-30) [Compare Source](https://togithub.com/openai/openai-node/compare/v4.30.0...v4.31.0) Full Changelog: [v4.30.0...v4.31.0](https://togithub.com/openai/openai-node/compare/v4.30.0...v4.31.0) ##### Features - **api:** adding temperature parameter ([#​742](https://togithub.com/openai/openai-node/issues/742)) ([b173b05](https://togithub.com/openai/openai-node/commit/b173b05eb52266d8f2c835ec4ed71cba8cdc609b)) ##### Bug Fixes - **streaming:** trigger all event handlers with fromReadableStream ([#​741](https://togithub.com/openai/openai-node/issues/741)) ([7b1e593](https://togithub.com/openai/openai-node/commit/7b1e5937d97b309ed51928b4388dcde74abda8dc)) ### [`v4.30.0`](https://togithub.com/openai/openai-node/blob/HEAD/CHANGELOG.md#4300-2024-03-28) [Compare Source](https://togithub.com/openai/openai-node/compare/v4.29.2...v4.30.0) Full Changelog: [v4.29.2...v4.30.0](https://togithub.com/openai/openai-node/compare/v4.29.2...v4.30.0) ##### Features - assistant fromReadableStream ([#​738](https://togithub.com/openai/openai-node/issues/738)) ([8f4ba18](https://togithub.com/openai/openai-node/commit/8f4ba18268797d6c54c393d701b13c7ff2aa71bc)) ##### Bug Fixes - **client:** correctly send deno version header ([#​736](https://togithub.com/openai/openai-node/issues/736)) ([b7ea175](https://togithub.com/openai/openai-node/commit/b7ea175b2854909de77b920dd25613f1d2daefd6)) - **example:** correcting example ([#​739](https://togithub.com/openai/openai-node/issues/739)) ([a819551](https://togithub.com/openai/openai-node/commit/a81955175da24e196490a38850bbf6f9b6779ea8)) - handle process.env being undefined in debug func ([#​733](https://togithub.com/openai/openai-node/issues/733)) ([2baa149](https://togithub.com/openai/openai-node/commit/2baa1491f7834f779ca49c3027d2344ead412dd2)) - **internal:** make toFile use input file's options ([#​727](https://togithub.com/openai/openai-node/issues/727)) ([15880d7](https://togithub.com/openai/openai-node/commit/15880d77b6c1cf58a6b9cfdbf7ae4442cdbddbd6)) ##### Chores - **internal:** add type ([#​737](https://togithub.com/openai/openai-node/issues/737)) ([18c1989](https://togithub.com/openai/openai-node/commit/18c19891f783019517d7961fe03c4d98de0fcf93)) ##### Documentation - **readme:** consistent use of sentence case in headings ([#​729](https://togithub.com/openai/openai-node/issues/729)) ([7e515fd](https://togithub.com/openai/openai-node/commit/7e515fde433ebfb7871d75d53915eef05a08a916)) - **readme:** document how to make undocumented requests ([#​730](https://togithub.com/openai/openai-node/issues/730)) ([a06d861](https://togithub.com/openai/openai-node/commit/a06d861a015eeee411fa2c6ed9bf3000313cfc03)) </details> <details> <summary>tailwindlabs/tailwindcss (tailwindcss)</summary> ### [`v3.4.3`](https://togithub.com/tailwindlabs/tailwindcss/compare/v3.4.2...f1f419a9ecfcd00a2001ee96ab252739fca47564) [Compare Source](https://togithub.com/tailwindlabs/tailwindcss/compare/v3.4.2...v3.4.3) ### [`v3.4.2`](https://togithub.com/tailwindlabs/tailwindcss/releases/tag/v3.4.2) [Compare Source](https://togithub.com/tailwindlabs/tailwindcss/compare/v3.4.1...v3.4.2) ##### Fixed - Ensure max specificity of `0,0,1` for button and input Preflight rules ([#​12735](https://togithub.com/tailwindlabs/tailwindcss/pull/12735)) - Improve glob handling for folders with `(`, `)`, `[` or `]` in the file path ([#​12715](https://togithub.com/tailwindlabs/tailwindcss/pull/12715)) - Split `:has` rules when using `experimental.optimizeUniversalDefaults` ([#​12736](https://togithub.com/tailwindlabs/tailwindcss/pull/12736)) - Sort arbitrary properties alphabetically across multiple class lists ([#​12911](https://togithub.com/tailwindlabs/tailwindcss/pull/12911)) - Add `mix-blend-plus-darker` utility ([#​12923](https://togithub.com/tailwindlabs/tailwindcss/pull/12923)) - Ensure dashes are allowed in variant modifiers ([#​13303](https://togithub.com/tailwindlabs/tailwindcss/pull/13303)) - Fix crash showing completions in Intellisense when using a custom separator ([#​13306](https://togithub.com/tailwindlabs/tailwindcss/pull/13306)) - Transpile `import.meta.url` in config files ([#​13322](https://togithub.com/tailwindlabs/tailwindcss/pull/13322)) - Reset letter spacing for form elements ([#​13150](https://togithub.com/tailwindlabs/tailwindcss/pull/13150)) - Fix missing `xx-large` and remove double `x-large` absolute size ([#​13324](https://togithub.com/tailwindlabs/tailwindcss/pull/13324)) - Don't error when encountering nested CSS unless trying to `@apply` a class that uses nesting ([#​13325](https://togithub.com/tailwindlabs/tailwindcss/pull/13325)) - Ensure that arbitrary properties respect `important` configuration ([#​13353](https://togithub.com/tailwindlabs/tailwindcss/pull/13353)) - Change dark mode selector so `@apply` works correctly with pseudo elements ([#​13379](https://togithub.com/tailwindlabs/tailwindcss/pull/13379)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/autoblocksai/autoblocks-examples). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Dragging list items now works as expected and allows dragging multiple nodes.